Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text'

15 msg	[2.6 patch] kernel/sched*: optimize inlining
2 msg	Re: [PATCH] MMC/SD host driver for Ricoh Bay1Co...
1 msg	Re: [PATCH] Remove *.rej pattern from .gitignore
3 msg	[PATCH] x86: make e820.c to have common functions
10 msg	[patch] video: build fix for drivers/media/vide...
2 msg	Loan Offer
2 msg	[PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() ...
2 msg	[PATCH] I2C: SiByte: Correct a comment about fr...
1 msg	[PATCH] RTC: M41T80: Use pr_info() as appropriate
1 msg	[PATCH] RTC: M41T80: Sort header inclusions for...
2 msg	[PATCH] sched: fix defined-but-unused warning
5 msg	[PATCH 1/5] scsi: sd: optionally set power cond...
4 msg	[PATCH 1/1] USB HID/HIDBP DRIVERS: Add iMON LCD...
2 msg	[PATCH 3/3] PNP: add ISAPnP MPU option quirks
1 msg	[PATCH 2/3] PNP: add pnp_build_option() to the API
1 msg	[PATCH 1/3] PNP: cleanup pnp_fixup_device()
1 msg	[2.6.24] [Q] x86: clear DF before calling signa...
5 msg	2.6.26-rc1 fails to boot

2.6.26-rc1 on x86: ld: warning: dot moved backw...
\ Mikael Pettersson (10 May 2008)
. \ Rafael J. Wysocki (10 May 2008)
. \ H. Peter Anvin (10 May 2008)
. . \ Rafael J. Wysocki (10 May 2008)
. . . \ Pavel Machek (11 May 2008)
. . \ Sam Ravnborg (10 May 2008)
. . . \ Cyrill Gorcunov (11 May 2008)
. . . . \ H. Peter Anvin (11 May 2008)
. . . . . \ Cyrill Gorcunov (11 May 2008)
. . . . . . \ H. Peter Anvin (11 May 2008)
. . . . . . . \ Cyrill Gorcunov (11 May 2008)
. . . . . . . . \ Rafael J. Wysocki (11 May 2008)
. . . . . . . . . \ Cyrill Gorcunov (12 May 2008)
. . . . . . . . . . \ Cyrill Gorcunov (12 May 2008)
. . . . . . . . . \ Pavel Machek (12 May 2008)
. . . . \ Pavel Machek (11 May 2008)

3 msg	HDIO_DRIVE_CMD failed on Dell Latitude D630

Subject:	Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text'
Group:	Linux-kernel
From:	Rafael J. Wysocki
Date:	11 May 2008

On Sunday, 11 of May 2008, Cyrill Gorcunov wrote:
> [H. Peter Anvin - Sun, May 11, 2008 at 11:25:54AM -0700]
> > Cyrill Gorcunov wrote:
> >> Hi Peter,
> >> actually I only doubt about exactly position of this headers - I mean
> >> meguess it better should be _before_ "_end" not after. Since the others
> >> script uses (acpi/wakeup_rm.S):
> >> wakeup_code_start:
> >> .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin"
> >> wakeup_code_end:
> >> and kernel uses these wakeup_code_* marks to save/restore memory I think
> >> it should be like
> >> . = HEADER_OFFSET;
> >> .header : {
> >> ...
> >> }
> >> . = ALIGN(16);
> >> _end = .;
> >> /DISCARD/ ...
> >
> > Yes, I believe that's correct.
> >
> > -hpa
> >
>
> Thanks for review, Peter, I'll cook a patch and wait for
> Pavel's opinion ;-)

I've tested the appended one. If that's what you mean, we'll ask Ingo to take
it.

Thanks,
Rafael

---
arch/x86/kernel/acpi/realmode/wakeup.lds.S | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-2.6/arch/x86/kernel/acpi/realmode/wakeup.lds.S
===================================================================
--- linux-2.6.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S
+++ linux-2.6/arch/x86/kernel/acpi/realmode/wakeup.lds.S
@@ -12,11 +12,6 @@ ENTRY(_start)

SECTIONS
{
- . = HEADER_OFFSET;
- .header : {
- *(.header)
- }
-
. = 0;
.text : {
*(.text*)
@@ -50,6 +45,11 @@ SECTIONS
__bss_end = .;
}

+ . = HEADER_OFFSET;
+ .header : {
+ *(.header)
+ }
+
. = ALIGN(16);
_end = .;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/