| |||||||||||||||||||||||||||||||
|
> This code leaks up to var_line_limit bytes for every recipient. > Thank you very much for the code review. I agree with your statement and have updated the patch on my site. mystrdup does indeed an allocation which is not freed and unnecessary as the vstring is taking care of the allocation. The call was left as the pointer was initially a char* - which can be summarised with : me bad, no excuse ! I have not run any test on this new patch and only replaced my local machine /usr/lib/postifx/smtpd and send mails to a few recipients with the previous to check if there could be any other problems. I intend to perform some testing of the border case as soon as humanly possible - meaning most likely the first week of December due to my current work commitments. Thank you for your help. Thomas
| ||||||||||||||||||||||||||||||
© 2004-2008 readlist.com