Please help critcize and shorten my sub code

4 msg	log missing images
2 msg	database Cgi query's
3 msg	File opening problem
3 msg	$^I
4 msg	Can't run PERL scripts on a shared server?
7 msg	comparing two binary numbers

Please help critcize and shorten my sub code
\ Richard Lee (10 May 2008)
. \ Jenda Krynicky (11 May 2008)
. . \ Richard Lee (11 May 2008)
. . . \ Jenda Krynicky (11 May 2008)
. . . . \ Richard Lee (11 May 2008)
. \ Peter Scott (11 May 2008)
. . \ Jenda Krynicky (11 May 2008)
. . . \ Rob Dixon (11 May 2008)

3 msg	split slice question
4 msg	perl-support for vim help needed
4 msg	Text to hex
1 msg	Perl MQSeries API newbie help
3 msg	dns error or module error?
3 msg	script for an mbox
4 msg	deleting a user name from a file
1 msg	Documentation problem
5 msg	one liner for for and if
3 msg	error in printing unicode
2 msg	install module problem
1 msg	Can't get Text::Balanced::extract_quotelike to ...
3 msg	Regex help?

Subject:	Please help critcize and shorten my sub code
Group:	Perl-beginners
From:	Richard Lee
Date:	10 May 2008

I dont know how to go through the array over and over again pending on
my previous search so I ended up writing it like below which works.. but
looks really really
inefficient..

sub dd_fact {
my $routename = shift;
my $routegroupid;
my $trunkgroupid;
my $carriername;
my $carrier_active;
my $carrierid;
AHI: for (@dat) {
if (exists $_->{outsideroute_group_m}{route_name}
and $_->{outsideroute_group_m}{route_name} eq "$routename") {
$routegroupid = $_->{outsideroute_group_m}{route_group_id};
last AHI;
}
}

EWF: for (@dat) {
if (exists $_->{outsideroute_trunk_m}{route_group_id}
and $_->{outsideroute_trunk_m}{route_group_id} eq
"$routegroupid") {
$trunkgroupid = $_->{outsideroute_trunk_m}{trunkgroup_id};
last EWF;
}
}

WWW: for (@dat) {
if (exists $_->{outsideotrunkgroup_m}{trunkgroup_id}
and $_->{outsideotrunkgroup_m}{trunkgroup_id} eq
"$trunkgroupid") {
$carrierid = $_->{outsideotrunkgroup_m}{carrier_id};
last WWW;
}
}

for (@dat) {
if (exists $_->{outsidecarrier_m}{carrier_id}
and $_->{outsidecarrier_m}{carrier_id} eq "$carrierid") {
$carriername = $_->{outsidecarrier_m}{carrier_name};
$carrier_active = live($_->{outsidecarrier_m}{active});
return($trunkgroupid,$carriername,$carrier_active);
}
}
}

--
To unsubscribe, e-mail: beginners-unsubscribe
For additional commands, e-mail: beginners-help
http://learn.perl.org/