timewait state memory leak

1 msg	Fwd: [networking-discuss] uperf - A network ben...
27 msg	Problems with netgraph
1 msg	Re: kern/123429: [nfe] [hang] 'ifconfig nfe up'...

timewait state memory leak
\ Huang, Yusheng (5 May 2008)

1 msg	Re: Is it possible to change BSD licence to GPL...
4 msg	Change from BSDL to GPL
1 msg	Is it possible to change BSD licence to GPL for...
5 msg	Can I port 4.4BSD-Lite's TCP/IP protocol stack ...
3 msg	Trying to find source of collisions
1 msg	Re: kern/119516: [ip6] [panic] _mtx_lock_sleep:...
1 msg	Re: kern/122858: [nsswitch] nsswitch in 7.0 is ...
1 msg	Re: kern/91594: [em] FreeBSD > 5.4 w/ACPI fa...
1 msg	Re: kern/105925: Regression in ifconfig(8) + vl...
1 msg	Re: bin/108895: pppd(8): PPPoE dead connections...
1 msg	Re: kern/109308: [pppd] [panic] Multiple panics...
1 msg	Re: kern/109733: [bge] bge link state issues [r...
2 msg	Network Patches from -RELEASE to -STABLE 7.0
24 msg	Troubles with em on FreeBSD 7
13 msg	IPPROTO_DIVERT and PF_INET6
11 msg	MFC of em/igb drivers

Subject:	timewait state memory leak
Group:	Freebsd-net
From:	Huang, Yusheng
Date:	5 May 2008

Hi,

I am looking at the tcp_tw_2msl_scan() code and it looks like there is a
bug in there.

struct tcptw *
tcp_tw_2msl_scan(int reuse)
{
struct tcptw *tw;

INP_INFO_WLOCK_ASSERT(&tcbinfo);
for (;;) {
tw = TAILQ_FIRST(&twq_2msl);
if (tw == NULL || (!reuse && tw->tw_time > ticks))
^^^^^^^^^^^^^^^^^^
break;
INP_WLOCK(tw->tw_inpcb);
tcp_twclose(tw, reuse);
if (reuse)
return (tw);
}
return (NULL);
}

Shouldn't the comparison be TSTMP_GT(tw->tw_time, ticks)?

-yusheng

_______________________________________________
freebsd-net mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscribe"