HEADS UP: KBI breakage for Ethernet modules

6 msg	VIA VT8237R+ chipset
3 msg	MFC plans for TSO and VLAN??
2 msg	setenv() patch for POSIX and memory leak
2 msg	WITHOUT_PROFILE no longer honored?
1 msg	PAT_WRITE_COMBINING: how to use?
1 msg	/bin/df strangeness

HEADS UP: KBI breakage for Ethernet modules
\ Yar Tikhiy (29 May 2007)
. \ Scott Long (29 May 2007)
. . \ Yar Tikhiy (29 May 2007)

5 msg	CFT: re(4)
2 msg	if_iwi: modul not built in CURRENT
9 msg	ifconfig carp0 destroy = kernel panic
8 msg	Xorg port problem?
3 msg	No wpa_supplicant control socket at boot
1 msg	kldxref: file isn't dynamically-linked - techni...
7 msg	mplayer causes panic: page fault
5 msg	ldd broken for profiling binaries?
5 msg	Re: HEADS UP: compat6x
2 msg	libgcc_s.so.1 and libstdc++.so.6 are shadowed (...
7 msg	persistent problem with buildworld on -CURRENT
3 msg	FreeBSD/xen status
3 msg	mpt driver broken for big-endian ?

Subject:	HEADS UP: KBI breakage for Ethernet modules
Group:	Freebsd-current
From:	Yar Tikhiy
Date:	29 May 2007

On Sun, May 27, 2007 at 03:51:29PM +0400, Yar Tikhiy wrote:
> As discussed earlier on -net, I'd like to commit the following
> patch. It will bring ether_ioctl() into accord with ioctl() WRT
> the type of the command argument. In our ioctl(), command became
> an u_long ages ago, but ether_ioctl() has never been fixed. With
> int and u_long being of different widths on 64-bit arch'es, the
> discrepancy can get us in trouble sooner or later.
>
> In fact, ioctl command coding is very unlikely to change, so it
> will continue to fit in 32 bits. OTOH, the C compiler should be
> uneasy about squeezing u_long into int when ether_ioctl() is called
> from an if_ioctl handler, so this patch will be a little step on
> the way to a warning-free kernel.
>
> This change will inevitably break the kernel interface to network
> modules, so all of them will need rebuilding.

I received several positive replies and no negative ones, so the
change has just been committed. In fact, it breaks KBI on 64-bit
platforms only. (Thanks to Ruslan Ermilov for reminding me about
that.) Many thanks to those folks who encouraged the change.

Now all Ethernet-related kernel modules need to be rebuilt on 64-bit
platforms. The conventional "make buildkernel" procedure will take
care of stock modules, so only 3rd-party modules need some attention.

--
Yar
_______________________________________________
freebsd-current mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe"